Skip to content

Refactor xmldoc classes and handling in finalsink

Daniel Tang requested to merge refactor/xmldoc_handling/gracedb_alert into refactor/gracedb_alert

This MR is a refactor specifically focused on cleaning up the class definitions and usage for LIGO_LW XML document handling objects in postcoh_finalsink.py for the refactor/gracedb_alert branch (!53 (merged)).

There are three core XML document objects to refactor: SegmentDocument, PostcohDocument, and CoincsDocFromPostcoh. Each of these have LIGOLW xmldoc instances (stored as the xmldoc attribute), with a method (lambda function) called get_another() that we would like to refactor out. The objective of this refactor is to remove the get_another() method so we can just create new instances of classes in the standard Pythonic way, while also better handling the xmldoc cleanup code, specifically calls to xmldoc.unlink() and del.

Tests jobs are being run here on OzStar here: /fred/oz016/dtang/pipeline/tests/mr79.

Edited by Daniel Tang

Merge request reports