Skip to content

Use python based fix for gstvaluearray.

Timothy Davies requested to merge tdv-use-alternative-gstvaluearray-fix into spiir_compatibility_fixes

This reverts commit faafbd45, and replaces it entirely with the solution Patrick Godwin described here: lscsoft/spiir#70 (comment 602061)

There'll be a large set of changes due to the 2 steps. See the individual commits for nicer diffs. Once merged, the result in !8 (merged) should be simple to review.

It's far simpler, and works in my tests. PSDs in coincs have the exact same value when using a reference PSD, and it appears to read frame segments ok (which also had issues without either fix).

You can see the corresponding SPIIR changes here: lscsoft/spiir!230 (merged)

Edited by Timothy Davies

Merge request reports