- Dec 11, 2016
-
-
Edward Fauchon-Jones authored
- Fixes #2 - See merge request !3
-
Edward Fauchon-Jones authored
`galadirith/lvcnrpy:v1.0.0` already has all test dependencies to dramatically reduce test suite run time on Gitlab CI.
-
Edward Fauchon-Jones authored
- Dec 10, 2016
-
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored
The `Spec` class family were originally set up to work using class methods. This was natural because each `Spec` derivative only represented a single field. With the addition of the `Amplm` and `Phaselm` specs, this was no longer true, with each of these specs required to represent a collection of fields. While initially attempted to use instances for these `Specs` and classes+classmethods for the remaining specs, to much off the logic required casing on the `Spec` being an instance of class, it was decided to only use classes and classmethods. In the end this resulting in a massive anti-pattern, defining a class factory in place of instance initialisers in the `Amplm` and `Phaselm` classes, and a general bad logic. It made sense to use classmethods before, but in no longer did. This commit refactors most classmethods as instance methods (with a couple left as classmethods because theydo not reference the parent object, and could infact be staic methods). While a couple of expressions required additional `()` to instance `Specs`, overall the logic has been greatly simplified and actually demonstrated that the classmethod paradigm previously used had significantly little benifit.
-
Edward Fauchon-Jones authored
Add error to handle case when absolute value of the mode's order exceeds its degree.
-
Edward Fauchon-Jones authored
- Specs have been added that represent phase and amplitude modes. - 5 degrees with everyone order of phase and amp modes fields are now created by `createValidSim` - `lvcnrcheck` looks for and validates phase and amp modes.
-
- Dec 09, 2016
-
-
Edward Fauchon-Jones authored
- Fix romspline validation #1 - See merge request !2
-
Edward Fauchon-Jones authored
The test classes test the Specs and `lvcnrcheck`, that they only check for invalid fields right now doesn't matter and identifying invalid tests is for the test class methods name to confer.
-
Edward Fauchon-Jones authored
To distinguish the human readable `name` from the `name` of `InvalidValue`.
-
Edward Fauchon-Jones authored
Renamed and redoc'd to more accuratley describe its function.
-
Edward Fauchon-Jones authored
Identifiers were modified from ~component to ~subfield to make identifiers consitent.
-
Edward Fauchon-Jones authored
Each `Spec` derived class is now responsible for creating a valid field that it represents in a supplied `Sim` instance. Towards this, logic for creating valid fields was removed from the test helper.
-
Edward Fauchon-Jones authored
See merge request !1
-
Edward Fauchon-Jones authored
`Specs.valid` now return `Error` objects and the logic of generating errors and associated messages have been refactor to their own dedicated module. Much error message logic has now been removed from `lvcnrcheck` with only specific cases handled as nessesary, right now only a `Missing` `Error` needs to be cased.
- Dec 08, 2016
-
-
Edward Fauchon-Jones authored
Refactor generation of flattened attributes for simulations.
-
- Dec 06, 2016
-
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored
The dictionary keys are currently never actually used directly in the package. Loops go over the `k, v` of the dictionary `format1` however references to field names are only ever made through the `.name` attribute of `Spec` objects. Also fix docstrings in `Spec` classes to reference the correct format field.
-
Edward Fauchon-Jones authored
-
- Dec 05, 2016
-
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored
-
Edward Fauchon-Jones authored