Skip to content
Snippets Groups Projects

WIP: Add RAVEN VOEvent variant

Merged Brandon Piotrzkowski requested to merge brandon.piotrzkowski/gracedb:ravenvoevent into python3
1 unresolved thread
  • Add new fields to the VOEvent model here
  • Add processing of these fields to the superevents API here, including validation
  • Add processing and validation of these fields to the events API here
  • Add new fields to the VOEvent files here
  • Determine which external event needs to be included in the VOEvent
  • Load in external event
Edited by Brandon Piotrzkowski

Merge request reports

Pipeline #85365 failed

Pipeline failed for 08457eca on brandon.piotrzkowski:ravenvoevent

Approval is optional

Merged by Alexander PaceAlexander Pace 5 years ago (Oct 24, 2019 4:42pm UTC)

Merge details

  • Changes merged into master with bbb5da21.
  • Did not delete the source branch.

Pipeline #85472 failed

Pipeline failed for bbb5da21 on python3

Test coverage 30.00% from 0 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
60 60 obj_is_superevent = True
61 61 event = obj.preferred_event
62 62 graceid = obj.default_superevent_id
63 # ext_event = obj.em_events ???
  • I'm running into the issue that you brought up earlier @tanner.prestegard and that I was worried about: how exactly do we choose which external event to grab? Well we want the first one, that with the superevent, is publishable but there's no obvious way to know which at this step. I see a few possible solutions:

    1. Pass the external event ID as an argument when calling the VOEvent to be created in gwcelery
    2. Create a field within a superevent that determines which external event (or events) pass coincidence threshold that is updated in gwcelery
    3. Calculate which events pass coincidence threshold in gwcelery (bad because this would introduce a circular dependency on gwcelery.)
    Edited by Brandon Piotrzkowski
  • Follow-up to this: how do we get the external event here? It seems we need to give the superevent a property (say event.ext_event) with the external event dictionary prior to this, which I don't know exactly where or how to do this best.

  • Please register or sign in to reply
  • Brandon Piotrzkowski changed the description

    changed the description

  • added 12 commits

    Compare with previous version

  • added 8 commits

    • 78c93144 - Add RAVEN VOEvent variant
    • e2b06cb4 - Add processing to the superevent API
    • fd83907e - Add processing and validation in the API
    • 2f9d5221 - Fix bug accidently introduced
    • aec2feb1 - Question on getting data
    • b6eb2c42 - adding raven voevent fields
    • b9444798 - fixed raven_coinc
    • 0fefe7af - Build xml file from RAVEN entries

    Compare with previous version

  • added 1 commit

    • 08457eca - Build xml file from RAVEN entries

    Compare with previous version

  • Brandon Piotrzkowski marked the checklist item Add new fields to the VOEvent files here as completed

    marked the checklist item Add new fields to the VOEvent files here as completed

  • Brandon Piotrzkowski marked the checklist item Determine which external event needs to be included in the VOEvent as completed

    marked the checklist item Determine which external event needs to be included in the VOEvent as completed

  • Brandon Piotrzkowski changed the description

    changed the description

  • Please register or sign in to reply
    Loading