WIP: Add RAVEN VOEvent variant
-
Add new fields to the VOEvent model here -
Add processing of these fields to the superevents API here, including validation -
Add processing and validation of these fields to the events API here -
Add new fields to the VOEvent files here -
Determine which external event needs to be included in the VOEvent -
Load in external event
Merge request reports
Activity
marked the checklist item Add new fields to the VOEvent model here as completed
added 52 commits
-
7a5ee40b...799b051d - 51 commits from branch
lscsoft:python3
- 187ebd97 - Merge branch 'python3' of https://git.ligo.org/lscsoft/gracedb into ravenvoevent
-
7a5ee40b...799b051d - 51 commits from branch
@tanner.prestegard sorry I'm late on this (on your last day :( ). Going to try to do as much today as I can. Let me know if you see anything particularly abhorrent in the code.
marked the checklist item Add processing and validation of these fields to the events API here as completed
marked the checklist item Add processing of these fields to the superevents API here, including validation as completed
60 60 obj_is_superevent = True 61 61 event = obj.preferred_event 62 62 graceid = obj.default_superevent_id 63 # ext_event = obj.em_events ??? I'm running into the issue that you brought up earlier @tanner.prestegard and that I was worried about: how exactly do we choose which external event to grab? Well we want the first one, that with the superevent, is publishable but there's no obvious way to know which at this step. I see a few possible solutions:
- Pass the external event ID as an argument when calling the VOEvent to be created in gwcelery
- Create a field within a superevent that determines which external event (or events) pass coincidence threshold that is updated in gwcelery
- Calculate which events pass coincidence threshold in gwcelery (bad because this would introduce a circular dependency on gwcelery.)
Edited by Brandon Piotrzkowskichanged this line in version 9 of the diff
added 12 commits
Toggle commit list- Resolved by Brandon Piotrzkowski
- Resolved by Brandon Piotrzkowski
- Resolved by Brandon Piotrzkowski
- Resolved by Brandon Piotrzkowski
- Resolved by Brandon Piotrzkowski
added 8 commits
- 78c93144 - Add RAVEN VOEvent variant
- e2b06cb4 - Add processing to the superevent API
- fd83907e - Add processing and validation in the API
- 2f9d5221 - Fix bug accidently introduced
- aec2feb1 - Question on getting data
- b6eb2c42 - adding raven voevent fields
- b9444798 - fixed raven_coinc
- 0fefe7af - Build xml file from RAVEN entries
Toggle commit listmarked the checklist item Add new fields to the VOEvent files here as completed