I'm running into the issue that you brought up earlier @tanner.prestegard and that I was worried about: how exactly do we choose which external event to grab? Well we want the first one, that with the superevent, is publishable but there's no obvious way to know which at this step. I see a few possible solutions:
Pass the external event ID as an argument when calling the VOEvent to be created in gwcelery
Create a field within a superevent that determines which external event (or events) pass coincidence threshold that is updated in gwcelery
Calculate which events pass coincidence threshold in gwcelery (bad because this would introduce a circular dependency on gwcelery.)
Follow-up to this: how do we get the external event here? It seems we need to give the superevent a property (say event.ext_event) with the external event dictionary prior to this, which I don't know exactly where or how to do this best.
I'm running into the issue that you brought up earlier @tanner.prestegard and that I was worried about: how exactly do we choose which external event to grab? Well we want the first one, that with the superevent, is publishable but there's no obvious way to know which at this step. I see a few possible solutions:
Follow-up to this: how do we get the external event here? It seems we need to give the superevent a property (say event.ext_event) with the external event dictionary prior to this, which I don't know exactly where or how to do this best.
changed this line in version 9 of the diff