tests compare against git hash, eliminate cached .h5
This updates the test infrastructure to store a git hash of the reference code, instead of generated .h5 files. The test infrastructure creates a cache of the reference .h5 files from the specified git hash if it doesn't already exist, and then compares against that cache.
This gets rid of the need for git-lfs and the cached .h5 files, requiring instead the code is checked out from git.
Merge request reports
Activity
added 4 commits
-
93227f0c...0c79878c - 3 commits from branch
gwinc:master
- 54fcb2de - tests compare against git hash, eliminate cached .h5
-
93227f0c...0c79878c - 3 commits from branch
added 2 commits
I note that the one main slightly annoying procedural change with this method is that the reference can not be updated in the same commit as the noise change. Since the reference is pointing to a git commit, the noise change has to be updated in one commit, and then a separate commit is needed to update the reference (a commit can't know it's own commit id).
It also makes it a bit trickier to do development outside of git, but that may be a small price to pay for the convenience of not having to store traces in git-lfs.
Edited by Jameson Rollinsadded 1 commit
- 90923d1e - tests compare against git hash, eliminate cached .h5
mentioned in merge request !80 (merged)
- Automatically resolved by Jameson Rollins
- Automatically resolved by Jameson Rollins
- Automatically resolved by Jameson Rollins
- Automatically resolved by Jameson Rollins
- Automatically resolved by Jameson Rollins
- Resolved by Jameson Rollins
- Automatically resolved by Jameson Rollins
- Resolved by Jameson Rollins
- Resolved by Jameson Rollins
- Resolved by Jameson Rollins
Miscellaneous comments:
- How necessary is the whole cache management infrastructure here? Shouldn't gwinc run fast enough that the difference between running it once and running it twice is not very noticeable?
- This policy puts the onus on the submitter to ensure the tests pass and to update the test reference as necessary. It seems reasonable given that commands are provided to do so. However, I hope the approvers will be lenient and try to rehabilitate MRs that don't do this, recognizing that git-challenged people can still have things to teach us about the noise.
mentioned in merge request !82 (merged)
added enhancement label