Skip to content
Snippets Groups Projects

tests compare against git hash, eliminate cached .h5

Merged Jameson Rollins requested to merge jameson.rollins/pygwinc:test-git-ref into master

This updates the test infrastructure to store a git hash of the reference code, instead of generated .h5 files. The test infrastructure creates a cache of the reference .h5 files from the specified git hash if it doesn't already exist, and then compares against that cache.

This gets rid of the need for git-lfs and the cached .h5 files, requiring instead the code is checked out from git.

Edited by Jameson Rollins

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Christopher Wipf
  • Christopher Wipf
  • Christopher Wipf
  • Christopher Wipf
  • Christopher Wipf
  • Christopher Wipf
  • Christopher Wipf
    • Resolved by Jameson Rollins

      Miscellaneous comments:

      • How necessary is the whole cache management infrastructure here? Shouldn't gwinc run fast enough that the difference between running it once and running it twice is not very noticeable?
      • This policy puts the onus on the submitter to ensure the tests pass and to update the test reference as necessary. It seems reasonable given that commands are provided to do so. However, I hope the approvers will be lenient and try to rehabilitate MRs that don't do this, recognizing that git-challenged people can still have things to teach us about the noise.
  • Christopher Wipf mentioned in merge request !82 (merged)

    mentioned in merge request !82 (merged)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading