Revise suspension model
Re-implement corrections to the model from !61 (closed).
- Upper joint temperature comes from the stage above
- Drop support for BQuad suspension type
- Use the fiber end cross-section consistently in wireTELoss()
- Remove the "questionable approximation" in continuumWireKh
- Correct the spring constant calculation in continuumWireKv
Merge request reports
Activity
added noise label
mentioned in merge request !61 (closed)
added 3 commits
-
2133421a...9ff4ba54 - 2 commits from branch
master - c5083be5 - Revise suspension model
-
2133421a...9ff4ba54 - 2 commits from branch
@christopher.wipf @kevin.kuns @evan.hall I have rebased this on top of master, which now includes the changes from !61 (closed). I've also removed the Voyager updates from this series so we can see those separately. The report for just this change is here:
https://git.ligo.org/gwinc/pygwinc/-/jobs/742641/artifacts/file/gwinc_test_report.pdf
Please review this and I'll merge, then we can move on to the Voyager updates.
added 6 commits
-
c5083be5...08e466da - 5 commits from branch
master - 3d21a5d8 - Revise suspension model
-
c5083be5...08e466da - 5 commits from branch
added 2 commits
-
I have rebased this series against the test and CI updates. The pipeline won't pass until !81 (merged) is merged, at which point it will be using the new approval policy from !82 (merged), which will also need to be merged first.
mentioned in merge request !82 (merged)
added 6 commits
- a6caffc0 - tests compare against git hash, eliminate cached .h5
- 16b9ae40 - tests compare against git hash, eliminate cached .h5
- d7322e67 - CI: update image name
- 33204de4 - CI: add approval validation check for noise changing merge requests
- 9740732e - Revise suspension model
- b5f019d7 - update reference
Toggle commit listadded 8 commits
-
b5f019d7...6347de3a - 6 commits from branch
master - 06ec1593 - Revise suspension model
- bddefb44 - update reference
-
b5f019d7...6347de3a - 6 commits from branch
-
@christopher.wipf @evan.hall @kevin.kuns:
This MR is now using the new CI-based approval procedure. I added a commit that updates the reference. The check_approval pipeline job produced a report of the noise differences between this branch and master, which can be viewed from the "View exposed artifact" drop-down in the pipeline status section at the top. Once two people approve, the failed
review:check_approvaljob can be re-run, at which point the pipeline should succeed, after which the MR can be merged.I invite others to go through this process to become familiar with it and to verify that it works for everyone. Please let me know if there are any questions or issues.