MR approval check for noise changes
This series creates a new procedure for validating/approving noise changes in merge requests.
A special CI job is added that runs only on merge requests that update the test git ref, indicating that a noise has been changed. The MR will show present a report of the changed noises, and will block on MR approval. Once approval has been given, the review:check_approval job can be re-run, which should now pass, allowing the MR to proceed.
If the noises change but the reference has not been updated, then the CI pipeline will fail as usual.
See the updates to CONTRIBUTING for more details.
Merge request reports
Activity
added management label
added 1 commit
- a6f4ffe9 - CI: add approval validation check for noise changing merge requests
added 1 commit
- 5d14ef05 - CI: add approval validation check for noise changing merge requests
mentioned in merge request !80 (merged)
- Resolved by Christopher Wipf
Overall, I like this and !81 (merged) a lot. It looks like a smart use of the CI tools to make our workflow better.
Does this CI still work (or at least fail gracefully) in the event it's running in somebody's fork of the repo?
- Last reply by Jameson Rollins
mentioned in merge request !81 (merged)
-
I should note that !80 (merged) is now an example of this workflow in action. will be after !81 (merged) is merged
Edited by Jameson Rollins mentioned in commit 6347de3a
