FEAT: Precomputed calibration model
This MR adds a new Precomputed
calibration model. The idea of this is to use a set of precomputed calibration realisations and sample in the index of the line rather than the underlying model parameters.
This is similar to the method proposed in https://arxiv.org/abs/2009.10192 and has two advantages over the current method:
- only one new parameter per detector, rather than the standard 20 with the cubic spline.
- it can incorporate the physical calibration model described in the paper above.
I branched this from !1201 (merged) so the changes are a little confusing, but the new code, is essentially just the Precomputed
class.
Merge request reports
Activity
added 10-100 lines label
changed milestone to %2.0.0
added 5 commits
-
9bd97a82...ee78d544 - 4 commits from branch
master
- ab310d0c - Merge branch 'master' into 'precomputed-calibration'
-
9bd97a82...ee78d544 - 4 commits from branch
added 6 commits
-
ab310d0c...6c73e287 - 5 commits from branch
master
- 0a4c0110 - Merge branch 'master' into 'precomputed-calibration'
-
ab310d0c...6c73e287 - 5 commits from branch
requested review from @gregory.ashton, @sylvia.biscoveanu, @michael.williams, @soichiro.morisaki, and @ethan.payne
- Resolved by Colm Talbot
This looks good, but I can't seem to approve the MR. Can someone please approve on my behalf?
added 3 commits
-
0a4c0110...e98c55e8 - 2 commits from branch
master
- 6151a791 - Merge branch 'master' into 'precomputed-calibration'
-
0a4c0110...e98c55e8 - 2 commits from branch
I reduced the required number of approvals as there have been no changes since @gregory.ashton last approved.
mentioned in commit 6237355a
mentioned in merge request bilby_pipe!513 (merged)