Allow any lal dictionary option and add numerical_relativity_file

Hi @gregory.ashton @colm.talbot,

Since bilby_pipe!371 (closed) was in conflict with parallel_bilby, I have changed the strategy and modified bilby instead so now it works.

With this MR, bilby_pipe!371 (closed), !893 (closed) and !845 (closed) can be deleted/closed.

I have performed an NR injection (SXS0143) with parallel_bilby and compared with old results we had. Below there are some example plots. The values in the labels indicate the precessing version and final spin prescription I am passing to PhenomXPHM through the LAL dictionary. Blue and green are runs with the same PhenomXPHM settings but comparing an old private bilby and this MR. They both agree, and in red you have different PhenomXPHM settings and that's why it is a bit different.

This run was performed with the current master version of bilby_pipe and pBilby. Here they are the git hashes from the parallel_bilby_generation log:

'bilby_version': '1.0.3: (CLEAN) ef4a2f37 2020-11-18 10:00:09 +0100',

'bilby_pipe_version': '1.0.2: (CLEAN) c5febc3 2020-11-18 09:24:49 +0100',

'parallel_bilby_version': '0.1.6: (CLEAN) e59e706 2020-11-12 14:32:24 +1100'

The config file for pBilby I used was config.ini

changed the description

Thanks @cecilio.garcia-quiros! I think this is a good idea to include in Bilby.

@gregory.ashton @moritz.huebner do you think we should suggest to users (probably in a post 1.1 release) that they not use, e.g., pn_spin_order and use PNSpinOrder instead so that this new method will catch those and we can remove the lines which explicitly look for those parameters?

resolved all threads

added 1 commit

• 2fb10cf9 - Compress if statement

Compare with previous version

changed milestone to %1.1.0

@gregory.ashton @colm.talbot sorry for bothering you again. Can this be merged or is there anything else you would like to see? Having this in master would be very useful for the analysis of exceptional O3 events.

Hi @cecilio.garcia-quiros sorry for the delay. Functionally, the code looks okay, but I have a few quick concerns

1. It isn't clear to me how to use it. Is there a reference for what we can put in? I.e. in your example ini you have

waveform-arguments-dict = {PhenomXPrecVersion:102, PhenomXPFinalSpinMod:0}

2. Second, I'm confused by these lines

    for key, value in waveform_kwargs.items():
        func = getattr(lalsim, "SimInspiralWaveformParamsInsert" + key, 0)
        if func != 0:
            func(waveform_dictionary, value)

Is func always callable? I would very much appreciate a comment saying what these lines do as it is quite unclear to me. 3. There aren't any tests set up for this functionality. This means that future people modifying the code may break the functionality without knowing it. Is it possible to add tests? I'm happy to help do this, but it isn't clear to me how to use the code so I'm not sure how to write the tests.

added 6 commits

• 2fb10cf9...3cd2bff8 - 4 commits from branch lscsoft:master
• 24dc91f6 - Add tests and change 0->None
• 56cdc7d5 - Merge branch 'master' into cecilio.garcia-quiros/bilby-lal-wf-dict

Compare with previous version

approved this merge request

mentioned in merge request !893 (closed)

mentioned in merge request !845 (closed)

mentioned in merge request bilby_pipe!371 (closed)

approved this merge request

added Feature-request label

resolved all threads

mentioned in issue #547 (closed)

merged

mentioned in commit 3a42e5a8

mentioned in merge request !928 (merged)