Skip to content

Remove support for version 1 of the SFT file format

Karl Wette requested to merge (removed):remove-v1-SFT-support into master

Description

The version 1 SFT file format is a long-obsolete file format, and has not been in active use in the CW group for at least 10 years, probably longer. (Version 2 of the format dates from around 2004.) It is very unlikely any useful data remains in the version 1 format - and in any case in the unlikely occurrence of such an event, older versions of LALSuite can be used to read such data and convert to the version 2 format. Removing obsolete code reduces library size and aids maintenance.

Note that a copy of the SFT file I/O code - including version 1 SFT support - still exists in lalapps/src/pulsar/Fscan/spec_avg_long.c. This code will not be removed (!1378 (closed)) until a test is written for lalapps_spec_avg_long (#331 (closed))

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

(Formally, this merge request does not change the public API of LALPulsar.)

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

@david-keitel

Edited by Ghost User

Merge request reports

Loading