Fixing spin contributions to orbital angular momentum in SpinTaylorTx precession equations
Compare changes
Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 22 April 2025 starting at approximately 9am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk. This maintenance will be upgrading the GitLab database in order to be ready for the migration.
This branch introduces new features into the SpinTaylor precession equations:
The new features required a rationalization of the "XLALSimInspiralSpinTaylorTxCoeffs". In particular one input variable (flag) has been added to XLALSimInspiralSpinTaylorT4Setup(), XLALSimSpinTaylorEnergySpinDerivativeSetup(), to allow phenomtp approximant to call spin-corrections à la carte. and the function XLALSimInspiralSpinTaylorT4Derivatives() renamed to XLALSimInspiralSpinTaylorT4DerivativesAvg(), same for XLALSimInspiralSpinDerivatives() --> XLALSimInspiralSpinDerivativesAvg(), and XLALSimInspiralSetEnergyPNTerms() XLALSimInspiralSetEnergyPNTermsAvg(), to stress that it implements orbit-averaged dynamics, not instantaneous one. Note that the function XLALSimInspiralSpinTaylorOrbitalDriver() has been added to be used to return full dynamics of the orbital variables.
This merge request replace the old !1594 (closed) which in turns replaced !1412 (closed)
Review ongoing, see https://git.ligo.org/waveforms/reviews/lalsimulation.siminspiralspintaylorpnevolveorbit/-/wikis/home