Skip to content

Fixing spin contributions to orbital angular momentum in SpinTaylorTx precession equations

Riccardo Sturani requested to merge riccardo-sturani/lalsuite:fix_ls_master_rebase into master

Description

This branch introduces new features into the SpinTaylor precession equations:

  • it completes the introduction of a flag that can switch on spin dependent term in the orbital angular momentum

API Changes and Justification

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

The new features required a rationalization of the "XLALSimInspiralSpinTaylorTxCoeffs". In particular one input variable (flag) has been added to XLALSimInspiralSpinTaylorT4Setup(), XLALSimSpinTaylorEnergySpinDerivativeSetup(), to allow phenomtp approximant to call spin-corrections à la carte. and the function XLALSimInspiralSpinTaylorT4Derivatives() renamed to XLALSimInspiralSpinTaylorT4DerivativesAvg(), same for XLALSimInspiralSpinDerivatives() --> XLALSimInspiralSpinDerivativesAvg(), and XLALSimInspiralSetEnergyPNTerms() XLALSimInspiralSetEnergyPNTermsAvg(), to stress that it implements orbit-averaged dynamics, not instantaneous one. Note that the function XLALSimInspiralSpinTaylorOrbitalDriver() has been added to be used to return full dynamics of the orbital variables.

This merge request replace the old !1594 (closed) which in turns replaced !1412 (closed)

Review Status

Review ongoing, see https://git.ligo.org/waveforms/reviews/lalsimulation.siminspiralspintaylorpnevolveorbit/-/wikis/home

Edited by Riccardo Sturani

Merge request reports