Correct test mass RoCs in aLIGO ifo.yaml

See merge request !91

Addresses #52 (pending measurements for A+ test masses)

Fix coating brownian so it agrees with Hong

See merge request !87

fix relative imports

See merge request !89

Sebastian Steinlechner authored 4 years ago and Jameson Rollins committed 4 years ago

Budget import mechanism in load_budget currently doesn't allow for importing from sub-modules.  This fixes that issue.

closes #62

gwinc.test: inherit python interpreter

See merge request !88

Pass sys.executable to the gen_cache.sh script, instead of using a
hard-coded interpreter path

The small remaining discrepancy between Hong and gwinc is due to
an error in gwinc's implementation of the Yam et al model.

The coefficient in front of the phase derivative `dcdp_z` is
supposed to be `nN` (as written correctly in Yam et al, eq 1),
not `nN/2` (as found in gwinc).

In Hong et al, the coefficient is `nN/2`, but that's because
their phases are defined as one-way instead of round-trip (see
Yam et al, eq A2).

After correcting the error, gwinc and Hong agree, as expected,
for the case of equal bulk and shear losses and no
photoelasticity.

This should fix a bug whereby individual noise calibrations were not being
tracked internally properly.

The calibrations weren't being extracted properly from the noise tuples.

closes #58

also internal variable names for consistency

added the function for optimal squeeze angle. Works for A+

See merge request !36

Fix an error in the coating brownian noise calculation

See merge request !77

A discrepancy was found by Gabriele Vajente between the gwinc
CTN calculation and several other codes, especially in the case
of large Poisson ratio in the coating.

See: https://git.ligo.org/gabriele-vajente/thermal-noise-models

This commit resolves the discrepancy by fixing an apparent error
in the Yam et al calculation that was implemented in gwinc.

The job was comparing against "origin/master", which for MR submitted
from forks is likely not the target project.  This updates the API
script that fetches the MR info to also output the target project URL,
from which an 'upstream' remote is fetched for comparison.

Update silica thin film loss

See merge request !78

Voyager parameter update

See merge request !79

Cli improvements

Closes #53

See merge request !84

At some point this mode stopped producing plots.  This fixes that by
updating the code execution call to InteractiveShellEmbed.

Also only imports ipython opportunistically, so it's not a hard dependency.

This allows for saving budgets in multiple formats simultaneously, without
having to recalculate noises.

This will speed up some operations in the CI.

As was done in matgwinc some months ago

test look for upstream master by default, and minor fixes

See merge request !85

This changes the test to look for the upstream master in the user
current config and use that as the test reference by default.  This
seems like a more sensible default in general, and it's easy enough to
fall back to HEAD if need be ('-g HEAD').

This also fixes some things from the last commit:

* fixes the MR CI pipeline
* adds better command line documentation to the test
* fixes command help
* fixes bug in test cache pruing

simplify testing by removing unnecessary reference

See merge request !83

The assumption should really be that the HEAD of the repo is the
current noise reference.  There is therefore no need to store a
special reference hash for the tests.  This simplifies things quite a
bit, in particular by not requiring submitters to update a reference.

This commit drops the reference and modifies the test to just compare
the current code against HEAD by default.  The option to compare
against an arbitrary ref is preserved.

The CI is updated for these simplifications.  The "test" job is now
simple generation of the budgets.  The merge request approval job is
renamed 'review:noise_change_approval`, and it's logic remains mostly
the same: it compares the current budgets against the head of the MR
target branch, and requires the same MR approval to pass.  The overall
MR approval process therefor doesn't change.

This change got added accidentally from an earlier version of the
"test compare git hash" series during a rebase.

This reverts commit 16b9ae40.

Revise suspension model

See merge request !80

Upper joint temperature comes from the stage above
Drop support for BQuad suspension type
Use the fiber end cross-section consistently in wireTELoss()
Remove the "questionable approximation" in continuumWireKh
Correct the spring constant calculation in continuumWireKv